Skip to content

Add support for Puppet 6 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add support for Puppet 6 #225

wants to merge 1 commit into from

Conversation

mxey
Copy link

@mxey mxey commented Sep 11, 2020

Overview

This pull request introduces support for Puppet 6.

(Please write a summary of your pull request here. This paragraph should go into detail about what is changing, the motivation behind this change, and the approach you took.)

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

/cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]

@mxey mxey marked this pull request as ready for review September 14, 2020 08:51
@seanmil
Copy link
Contributor

seanmil commented Sep 15, 2020

FYI, I started working on this as well a few days ago just before this PR was opened. I noticed it today as I was preparing my PR #226 for the same issue. I don't care which one is merged, but it would be great to get Puppet 6 support included.

@mxey
Copy link
Author

mxey commented Sep 16, 2020

@seanmil Yours looks a lot more comprehensive. I haven't had time yet to look into the tests since the CI does not seem to be working on this repo.

@seanmil
Copy link
Contributor

seanmil commented Sep 16, 2020

@seanmil Yours looks a lot more comprehensive. I haven't had time yet to look into the tests since the CI does not seem to be working on this repo.

It took me many hours to sort all of the testing out. The tests weren't even all passing for me before I made any changes.

@mxey
Copy link
Author

mxey commented Oct 2, 2020

@seanmil I am closing my PR. I have started my Puppet 6 migration using your code, so thank you :)

@mxey mxey closed this Oct 2, 2020
@mxey mxey deleted the puppet6 branch October 2, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxey @seanmil